-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support attaching arbitrary binary files #454
base: master
Are you sure you want to change the base?
Conversation
Does it really makes sense to add this in a self-contained report? |
For any network-heavy software being tested, pcap files are equivalent (if not above) in importance to logfiles, so I don't really have any doubt in a "yes" to that. Especially since that's just one (pretty wide) use case, there's probably a bunch of others. Trying to think of some others, testing (de-)serialization feels like something where attaching random binaries would be pretty useful too. |
How would you consume that pcap file from the self-contained report? It's going to be base64 encoded. But maybe I'm misunderstanding something here? @eqvinox |
@BeyondEvil when you click the link for the file, the browser will open a file download dialog and save it decoded. (The download dialog would probably list wireshark too, as an application to directly open the file with. The file is first saved to |
Ah, got it. Ok, I'll add this to next-gen. Thanks! |
Missed this is during initial work of v4. Will try to get to it now. |
I'm not seeing the behavior described here. When I click the link, it just opens a new tab displaying the path to the binary. |
(Our testcases produce wireshark pcap files...)